[8.19] fix % in Arguments warnings #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/branch/_8_19__fix___in_arguments_warnings
branch
from
60f89ee to
819c0b9
Compare
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/_8_19__fix___in_arguments_warnings
branch
from
819c0b9 to
6b07450
Compare
|
I didn't check carefully, but this seems to be a straightforward seach-and-replace, so LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is for when we bump the minimal version of Coq to 8.19. It fixes a warning where
%was changed to%_and hence%inArgumentsis now deprecated. In the mean time, I will just disable this warning in the CI.For the record (because I totally forgot this earlier):
%means open scope deeply in the argument (in 8.20).%_means open scope shallowly in the argument (previous behaviour of%).